e7f6c3f4e82e4fb51d106a2352f047a33cb5e270

Author: Mark Story

Date: 2009-03-11 20:21:31 -0400

Minor refactor to array positions for scoring. Updated CSS and HTML

diff --git a/vendors/css/base.css b/vendors/css/base.css index 053f4b8..3e877ef 100644 --- a/vendors/css/base.css +++ b/vendors/css/base.css @@ -575,11 +575,13 @@ ol.code li code { .doc-issue { clear: both; margin-bottom: 1em; + border-bottom: 1px dotted #ccc; } -.doc-issue dt { - float: left; - clear: both; - margin: 0 1em 0 0; +.doc-issue h4 { + font-size: 16px; +} +.doc-issue ul { + margin: 0.5em 2em; } .doc-issue dd { margin: 0; diff --git a/vendors/doc_block_analyzer.php b/vendors/doc_block_analyzer.php index a55c121..a5ff42e 100644 --- a/vendors/doc_block_analyzer.php +++ b/vendors/doc_block_analyzer.php @@ -139,9 +139,11 @@ class DocBlockAnalyzer { $result = array( 'subject' => $element['name'], 'scores' => $scores, + 'totalScore' => $scores['totalScore'], ); + unset($result['scores']['totalScore']); $contentObjects++; - $contentScore += $scores['totalScore']; + $contentScore += $result['totalScore']; $results[$property][] = $result; } } else { @@ -151,7 +153,9 @@ class DocBlockAnalyzer { $results[$property] = array( 'subject' => $property, 'scores' => $scores, + 'totalScore' => $scores['totalScore'] ); + unset($results[$property]['scores']['totalScore']); } $results['sectionTotals'][$property] = array( 'elementCount' => $contentObjects, diff --git a/views/elements/docs_issue.ctp b/views/elements/docs_issue.ctp index aedd6c8..81aaac1 100644 --- a/views/elements/docs_issue.ctp +++ b/views/elements/docs_issue.ctp @@ -6,10 +6,9 @@ ?> <div class="doc-issue"> <h4><?php echo $issue['subject']; ?></h4> - <dl> + <ul> <?php foreach ($issue['scores'] as $problem): ?> - <dt><?php echo $problem['description']; ?></dt> - <dd><?php echo $problem['score']; ?></dd> + <li><strong><?php echo $problem['description']; ?></strong> <?php echo $problem['score']; ?></li> <?php endforeach; ?> - </dl> + </ul> </div> \ No newline at end of file